Sourcery refactored master branch #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Comment on lines
-56
to
+57
| for i in range(len(messages)): | ||
| msg = messages[i] | ||
| for message in messages: | ||
| msg = message |
There was a problem hiding this comment.
Function download_block refactored with the following changes:
- Replace index in for loop with direct reference (
for-index-replacement)
| if isinstance(file, str): | ||
| file_name = os.path.basename(file) | ||
| else: | ||
| file_name = str(file_id) | ||
|
|
||
| file_name = os.path.basename(file) if isinstance(file, str) else str(file_id) |
There was a problem hiding this comment.
Function TelegramClientX.upload_file refactored with the following changes:
- Swap positions of nested conditionals (
swap-nested-ifs) - Hoist repeated code outside conditional statement (
hoist-statement-from-if) - Replace if statement with if expression (
assign-if-exp)
Comment on lines
-1028
to
+1047
| if self.logger.isEnabledFor(logging.DEBUG): | ||
| timings = [(self.time_spent_traversing_tree, 'Traversing the tree'), | ||
| (self.time_spent_caching_nodes, 'Caching tree nodes'), | ||
| (self.time_spent_interning, 'Interning path components'), | ||
| (self.time_spent_writing_blocks, 'Writing data blocks'), | ||
| (self.time_spent_hashing, 'Hashing data blocks'), | ||
| (self.time_spent_querying_tree, 'Querying the tree')] | ||
| maxdescwidth = max([len(l) for t, l in timings]) + 3 | ||
| timings.sort(reverse=True) | ||
| uptime = time.time() - self.fs_mounted_at | ||
| printed_heading = False | ||
| for timespan, description in timings: | ||
| percentage = timespan / (uptime / 100) | ||
| if percentage >= 1: | ||
| if not printed_heading: | ||
| self.logger.debug("Cumulative timings of slowest operations:") | ||
| printed_heading = True | ||
| self.logger.debug( | ||
| " - %-*s%s (%i%%)" % (maxdescwidth, description + ':', format_timespan(timespan), percentage)) | ||
| if not self.logger.isEnabledFor(logging.DEBUG): | ||
| return | ||
| timings = [(self.time_spent_traversing_tree, 'Traversing the tree'), | ||
| (self.time_spent_caching_nodes, 'Caching tree nodes'), | ||
| (self.time_spent_interning, 'Interning path components'), | ||
| (self.time_spent_writing_blocks, 'Writing data blocks'), | ||
| (self.time_spent_hashing, 'Hashing data blocks'), | ||
| (self.time_spent_querying_tree, 'Querying the tree')] | ||
| maxdescwidth = max(len(l) for t, l in timings) + 3 | ||
| timings.sort(reverse=True) | ||
| uptime = time.time() - self.fs_mounted_at | ||
| printed_heading = False | ||
| for timespan, description in timings: | ||
| percentage = timespan / (uptime / 100) | ||
| if percentage >= 1: | ||
| if not printed_heading: | ||
| self.logger.debug("Cumulative timings of slowest operations:") | ||
| printed_heading = True | ||
| self.logger.debug( | ||
| " - %-*s%s (%i%%)" % (maxdescwidth, description + ':', format_timespan(timespan), percentage)) |
There was a problem hiding this comment.
Function DedupFS.__report_timings refactored with the following changes:
- Add guard clause (
last-if-guard) - Replace unneeded comprehension with generator (
comprehension-to-generator)
Comment on lines
-1066
to
+1067
| if nbytes == None: | ||
| if nbytes is None: |
There was a problem hiding this comment.
Function DedupFS.__report_throughput refactored with the following changes:
- Use x is None rather than x == None (
none-compare)
Comment on lines
+1082
to
+1084
| if not self.logger.isEnabledFor(logging.DEBUG): | ||
| return | ||
| printed_header = False |
There was a problem hiding this comment.
Function DedupFS.__report_top_blocks refactored with the following changes:
- Move assignments closer to their usage (
move-assign) - Add guard clause (
last-if-guard)
Comment on lines
-144
to
+146
| opta = [] | ||
| for o, v in self.optdict.iteritems(): | ||
| opta.append(o + '=' + v) | ||
| opta = [o + '=' + v for o, v in self.optdict.iteritems()] |
There was a problem hiding this comment.
Function FuseArgs.assemble refactored with the following changes:
- Convert for loop into list comprehension (
list-comprehension)
| if not 'indent_increment' in kw: | ||
| if 'indent_increment' not in kw: |
There was a problem hiding this comment.
Function FuseFormatter.__init__ refactored with the following changes:
- Simplify logical expression using De Morgan identities (
de-morgan)
| if not 'dest' in attrs: | ||
| if 'dest' not in attrs: |
There was a problem hiding this comment.
Function FuseOptParse.add_option refactored with the following changes:
- Simplify logical expression using De Morgan identities (
de-morgan)
| for f in fp: | ||
| yield f | ||
| yield from fp |
There was a problem hiding this comment.
Function feature_needs.resolve refactored with the following changes:
- Replace yield inside for loop with yield from (
yield-from) - Simplify logical expression using De Morgan identities (
de-morgan)
Comment on lines
-731
to
+733
| d = {'multithreaded': self.multithreaded and 1 or 0} | ||
| d['fuse_args'] = args or self.fuse_args.assemble() | ||
| d = { | ||
| 'multithreaded': self.multithreaded and 1 or 0, | ||
| 'fuse_args': args or self.fuse_args.assemble(), | ||
| } |
There was a problem hiding this comment.
Function Fuse.main refactored with the following changes:
- Merge dictionary assignment with declaration (
merge-dict-assign)
Sourcery Code Quality Report (beta)✅ Merging this PR will increase code quality in the affected files by 0.02 out of 10.
Here are some functions in these files that still need a tune-up:
Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run: