Docs/VSCodeConfiguration: Resolve all FIXMEs related to clang compiler #25024
+44
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
BertalanD
reviewed
Sep 16, 2024
Meta/serenity.sh
Outdated
Comment on lines
104
to
105
| [[ "${TOOLCHAIN_TYPE}" = "clang" ]] && TOOLCHAIN_TYPE='Clang' | ||
| if ! [[ "${TOOLCHAIN_TYPE}" =~ ^(GNU|Clang|clang)$ ]]; then |
There was a problem hiding this comment.
This comes from the tasks.json. The build directory is Build/x86_64clang. From the input value I am appending the compiler name to the build directory and also passing that same value to the Meta/serenity.sh run command-line.
There are only two valid compilers Clang and GNU. So if the compiler is clang, I am transforming it to Clang so that it is considered valid.
There was a problem hiding this comment.
If you remove it, then it will fail as invalid compiler. And making it case-insensitive everywhere doesn't make sense and could be error-prone.
There was a problem hiding this comment.
Hi @BertalanD, Could you please re-review the PR? Also I have removed clang from line 105 in b94c173
The `clang` is usually coming from the tasks.json file.
tbhaxor
force-pushed
the
fix/vscode-tasks
branch
from
dbf4e73
to
b94c173
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.