Cherry-pick "LibWeb: Implement type attribute validation for image loading" #25021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes image loading where unsupported image types are included in the list of source elements. (cherry picked from commit a0561ea9b24c72489221079ee6ca20103bdbb231)
github-actions
bot
added
the
👀 pr-needs-review
|
Right, these should be derived from ImageLoader, and some of these we don't support |
github-actions
bot
removed
the
👀 pr-needs-review
|
I remember intentionally not cherry picking this one a while ago, for the reasons you mention :) |
|
Yak added.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks LadybirdBrowser/ladybird#234
Generated with LBSync, did I do well?