Kernel/Net: Implement SO_SNDBUF and SO_RCVBUF for getsockopt #25012
+13
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
kleinesfilmroellchen
suggested changes
Sep 11, 2024
Kernel/Net/LocalSocket.cpp
Outdated
| if (size < sizeof(size_t)) | ||
| return EINVAL; | ||
| buffer_size = m_for_server.ptr()->space_for_writing(); | ||
| TRY(copy_to_user(static_ptr_cast<int*>(value), bit_cast<int*>(&buffer_size))); |
There was a problem hiding this comment.
Again, the pointer cast is utterly wrong and the type is size_t. This bit_cast is wrong and will be UB on big-endian systems.
There was a problem hiding this comment.
what cast should be used here? pointer cast seems to be used on everywhere else
logkos
force-pushed
the
socket
branch
5 times, most recently
from
3485f89
to
11384da
Compare
|
Hello! One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the |
logkos
force-pushed
the
socket
branch
3 times, most recently
from
ff3107b
to
84dabd3
Compare
logkos
changed the title
timschumi
reviewed
Sep 14, 2024
logkos
force-pushed
the
socket
branch
2 times, most recently
from
4372ed2
to
9fa49ec
Compare
These options are used for QoS and return buffer length as response. We currently don't support setting the buffer size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These options are generally used for QoS tuning by Apache, NGINX, MySQL etc. (insert anything that scales here)