Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kernel/Net: Cleanup the ICMP handler #25000

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Kernel/Net: Cleanup the ICMP handler #25000

wants to merge 1 commit into from
+20 −14

Commits on Sep 8, 2024

  1. Kernel/Net: Clean up the ICMP handler 

    This change fixes up handle_icmp to use a bit_cast instead of
a reinterpret_cast, which got used due to legacy reasons.

A few dbgln's got turned into dbgln_if's, in accordance with the
behavior throughout the rest of the file.

Furthermore, we revert a part of commit ad73ade which introduced
inconsistency between struct names. There's no ICMPv4, only ICMP and
ICMPv6. Thus, it makes more sense to revert the ICMPv4Type back to
ICMPType.

We also remove the FIXME about the TTL - as per RFC1700, TTL of 64 is
a recommended default, so the current behavior can stay.
    @sdomi
    sdomi committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    66127ea View commit details
    Browse the repository at this point in the history