Ext2FS+LibFileSystem: Make working with large files manageable #24998
+258
−147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
|
Hello! One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the |
implicitfield
force-pushed
the
ext2fs-cache
branch
3 times, most recently
from
e68b5f4
to
581123a
Compare
For some context, write_bytes_locked used to simply bail out before writing any data if there weren't enough blocks to cover the entire size of an inode before 1bf7f99. We're not actually restoring that behavior here, since computing the amount of blocks to be allocated would get exceedingly complex, considering that there could always be holes in between already allocated blocks. Instead, this simply makes allocate_blocks() bail out properly if there aren't any free blocks left. Fixes SerenityOS#24980
With this patch, we now only cache at most 10 000 blocks, which greatly relieves memory pressure when working with large files.
This prevents us from running out of memory when copying large files.
implicitfield
force-pushed
the
ext2fs-cache
branch
from
581123a
to
a4553b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details. The biggest change here is that we no longer store entire block lists in memory, since that can OOM way too easily. Instead, we now keep a 'view' to the actual block list, which can hold up to 10 000 blocks at once.