Vyankatesh 🍉

[VyankateshRohokale]

Migration: Replace DeprecatedFlyString with FlyString #22447
Replaced DeprecatedFlyString with FlyString

[BuggieBot]

Hello!

One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

[VyankateshRohokale]

It wont complete without Return 0 , until deprecatedFlyString is not replaced everywhere in my opinion

[logkos]

It wont complete without Return 0 , until deprecatedFlyString is not replaced everywhere in my opinion

no you need to satisfy lint and follow PR/commit name format

[VyankateshRohokale]

can you please elaborate?? , this is my first Open Source Contribution

…

On Sat, Sep 7, 2024 at 5:14 PM logkos ***@***.***> wrote: It wont complete without Return 0 , until deprecatedFlyString is not replaced everywhere in my opinion no you need to satisfy lint and follow PR/commit name format — Reply to this email directly, view it on GitHub <#24997 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BBAZP2X7W2GR5FXVU6LSGGDZVLRINAVCNFSM6AAAAABNZ42ALCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZVGE3DCNBXGE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[skyrising]

Looks like this is just a partial find & replace of "DeprecatedFlyString" with "FlyString".
That's not the goal of #22447 and doesn't even compile, as you can see with the failing CI.