AK: Array and Tuple structured bindings #24993
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For structured bindings, these have to be defined in the std namespace.
|
Hello! One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the |
github-actions
bot
added
the
👀 pr-needs-review
This ensures that the result of calling get() on a temporary Tuple cannot be assigned to a lvalue reference.
nrdmn
force-pushed
the
array-structured-bindings
branch
from
5d21187
to
58f83a6
Compare
|
Welcome to the project! Do you have a use-case for these changes? We generally don't add library features for the case of adding features. Also note that the consensus is (or, at least, was) to prefer dedicated structures over tuples for situations that might require convenient unpacking. See a relatively recent discussion on Discord around this message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows Array and Tuple to be used in structured binding declarations.
This is a new copy of #24986 because apparently I can't re-open closed PRs.