AK/Optional: Make some member functions constexpr #24978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
nrdmn
changed the title
|
This PR currently breaks at Userland/Applications/PixelPaint/Tools/MoveTool.cpp:63 because there's an assignment to an Optional<const ....>. But so would std::optional: https://godbolt.org/z/z8c68e94Y |
|
Thaat looks like a logic bug, feel free to fix it |
|
squashed the 'fixup' commits |
nrdmn
changed the title
BertalanD
requested changes
Sep 1, 2024
nrdmn
force-pushed
the
optional
branch
2 times, most recently
from
802df7a
to
d5961c5
Compare
Hendiadyoin1
reviewed
Sep 1, 2024
construct_at has to be defined in the std namespace because outside of it, compilers wouldn't allow it to be constexpr because of its use of placement new.
This will allow Optional's Ctors to be constexpr. Switching Optional's m_storage to be a union member is necessary if we want to avoid pointer conversions, which we won't be allowed to do when those functions are constexpr.
|
With films work on Optional<T&>, this now has conficts |
Hendiadyoin1
added
the
⚠️ pr-has-conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes some of Optional's member functions to be constexpr - for now only the non-reference variant. Notably, this requires using construct_at instead of placement new to create the contained object and storing it in a union instead of a byte buffer.