Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(previews): sidebar message previews fix for sent attachments #584

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

Jekrimo
Copy link
Contributor

@Jekrimo Jekrimo commented Sep 19, 2024

What this PR does 📖

  • Added a comparative to check against last_message_id where if there isn't one we show "No messages sent yet." and if there is but last_message_preview is "" then we show "New Attachement", otherwise show the last message

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

Additional comments 🎤

I think if we could get some extra properties onto our Message types we could clean some of the logic up but from what I understand that would take some extra Warp magic that I don't understand

@github-actions github-actions bot added the Missing dev review Two dev reviews are required on PR label Sep 19, 2024
Copy link

Automated Test Results

passed  119 passed
flaky  1 flaky
skipped  4 skipped

Details

stats  124 tests across 16 suites
duration  18 minutes, 56 seconds
commit  fc84471

Flaky tests

Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B7, B57, B58 - Favorites tests

Skipped tests

Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B8 to B14 - Quick Profile Local and Remote - Updating note
Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B8 to B14 - Quick Profile Local - Updating username, status, banner and profile picture
Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B8 to B14 - Quick Profile Remote - Updating username, status, banner and profile picture
Automated Tests on Chrome Desktop › 20-settings-developer.spec.ts › Settings Developer Tests › T4 - Clicking Clear State should clear users state

Copy link

Playwright test execution is complete! You can find the test results report here

@Satellite-im Satellite-im deleted a comment from github-actions bot Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Missing dev review Two dev reviews are required on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(chat): "No messages sent yet" in sidebar when sending attachments
1 participant