fix(platform): fdp-table sorting visible columns state get lost #12429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 56570af): https://fundamental-ngx-gh--pr12429-fix-fdp-table-fdp-t-t924fonh.web.app (expires Sat, 21 Sep 2024 09:35:41 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff |
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
libs/platform/table/components/table-p13-dialog/columns/columns.component.ts
Outdated
Show resolved
Hide resolved
| @@ -329,11 +320,11 @@ export class P13ColumnsDialogComponent implements Resettable, OnInit, OnDestroy | |||
| .pipe(debounceTime(20)) | |||
| .subscribe(([showAll, searchQuery]) => { | |||
| this._filteredColumns = this._selectableColumns | |||
| .sort((a, b) => a.order - b.order) | |||
There was a problem hiding this comment.
i think instead of sort it here you can sort it inside _initiateColumns method, with that way you can reduce manipulation on array.
…umns-state-get-lost
…-visible-columns-state-get-lost' into fix(fdp-table)-fdp-table-sorting-visible-columns-state-get-lost
mikerodonnell89
approved these changes
Sep 19, 2024
mikerodonnell89
requested changes
Sep 19, 2024
| @@ -292,25 +294,18 @@ export class P13ColumnsDialogComponent implements Resettable, OnInit, OnDestroy | |||
| */ | |||
| private _initiateColumns(visibleColumnKeys: string[]): void { | |||
| const visibleColumnIndexMap = new Map(visibleColumnKeys.map((key, index) => [key, index])); | |||
| console.log(this.availableColumns); | |||
There was a problem hiding this comment.
Works well, just pull this console log out before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes (#12397)[https://github.com//issues/12397]
Description
Ensures the sort order of visible columns is maintained within the customization visible columns dialog of the fdp-table component. This fix prevents the columns from reverting to their original order when the dialog is reopened.