Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(platform): icon tab bar dynamic content #12428

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat(platform): icon tab bar dynamic content #12428

wants to merge 10 commits into from

Conversation

khotcholava
Copy link
Contributor

@khotcholava khotcholava commented Sep 16, 2024 •
edited by dpavlenishvili
Loading

fix(platform): Extend icon tab bar to accept user defined HTML structure as the tab link template

closes #11771

Description

  • Added support for custom tab link templates to enhance flexibility.
  • Ensured compatibility with Angular RouterLink functionality.

khotcholavaSuzy and others added 10 commits September 6, 2024 13:40
@khotcholavaSuzy
fix(platform): Extend icon tab bar to accept user defined HTML struct…
ecb240d 
…ure as the tab link template

closes [#11771](#11771)

## Description
- Implementing platform icon tab bar dynamic content
@khotcholavaSuzy
fix(platform): Extend icon tab bar to accept user defined HTML struct…
1ecf0c4 
…ure as the tab link template

closes [#11771](#11771)

## Description
- Implemented title directive to apply complex tab title
@khotcholava
feat(platform): TABS added dynamic template support to platform tabs
4d67b0b 
closes:[#11771](#11771)
## Description
- Added dynamic template support to tabs
@khotcholavaSuzy
fix(platform): Extend icon tab bat to accept user defined HTML
da5aca1 
closes [#11771](#11771)

## Description
- Added custom tab title and content example
@khotcholava
feat(platform): Icon tab bar content
3beb6d4 
closes:[#11771](#11771)
## Description
- Implementing dynamic content for icon tab bar
@khotcholava
fix(platform): Extend icon tab bar to accept user defined HTML struct…
85a37ec 
…ure as the tab link template

closes (#11771)[#11771]

## Description
Implemented dynamic html content structure for icon type tabs
@khotcholava
fix(platform): Extend icon tab bar to accept user defined HTML struct…
d2047ee 
…ure as the tab link template

closes (#11771)[#11771]

## Description
Implemented defined html tab title for process type tabs
@khotcholava
fix(platform): Extend icon tab bar to accept user defined HTML struct…
1447aa8 
…ure as the tab link template

closes (#11771)[#11771]

## Description
Implemented defined html tab title for process type tabs
@khotcholava
fix(platform): Extend icon tab bar to accept user defined HTML struct…
c1e99f8 
…ure as the tab link template

closes (#11771)[#11771]

## Description
Implemented defined html tab title for filter type tabs
@khotcholava
Merge branch 'main' into feat-platfor-icon-tab-bar-dynamic-content
0c0fa88
@khotcholava khotcholava self-assigned this Sep 16, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 16, 2024

✅ Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit 0c0fa88
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/66e80823bce65300089a54b2
😎 Deploy Preview https://deploy-preview-12428--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

Visit the preview URL for this PR (updated for commit 0c0fa88):

https://fundamental-ngx-gh--pr12428-feat-platfor-icon-ta-o7l5x61w.web.app

(expires Thu, 19 Sep 2024 10:32:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

@dpavlenishvili dpavlenishvili changed the title Feat platfor icon tab bar dynamic content feat(platform): icon tab bar dynamic content Sep 16, 2024
@droshev droshev requested a review from a team September 16, 2024 19:30
@droshev droshev added this to the Sprint 138 - September 2024 milestone Sep 16, 2024
mikerodonnell89
mikerodonnell89 reviewed Sep 19, 2024
View reviewed changes
libs/platform/icon-tab-bar/directives/icon-tab-title.directive.ts
selector: '[fdpIconTabBarTitleTemplate], [fdp-icon-tab-bar-title-template]',
standalone: true
})
export class IconTabTitleDirective {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this directive? As far as I can tell, this adds no benefit, we should just let the developer do this instead:

    <fdp-icon-tab-bar-tab>
        <span>User Defined Title</span>
        <div class="tab-container-example">Custom tab content</div>
    </fdp-icon-tab-bar-tab>

mikerodonnell89
mikerodonnell89 requested changes Sep 19, 2024
View reviewed changes
Copy link
Member

@mikerodonnell89 mikerodonnell89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comment about the IconTabTitleDirective

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikerodonnell89 mikerodonnell89 mikerodonnell89 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@khotcholava khotcholava

Labels
None yet
Projects
None yet
Milestone
Sprint 138 - September 2024
Development

Successfully merging this pull request may close these issues.

Extend icon tab bar to accept user defined HTML structure as the tab link template
4 participants
@khotcholava @mikerodonnell89 @droshev @khotcholavaSuzy