Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): implement ContentDensity to handle all type of themes on demand. #12370

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dpavlenishvili
Copy link
Contributor

…nsity to handle all type of themes on demand.

Related Issue(s)

closes #11368

Description

Screenshots

Before:

After:

Please check whether the PR fulfills the following requirements

During Implementation
  1. Visual Testing:
  • visual misalignments/updates
  • check Light/Dark/HCB/HCW themes
  • RTL/LTR - proper rendering and labeling
  • responsiveness(resize)
  • Content Density (Cozy/Compact/(Condensed))
  • States - hover/disabled/focused/active/on click/selected/selected hover/press state
  • Interaction/Animation - open/close, expand/collapse, add/remove, check/uncheck
  • Mouse vs. Keyboard support
  • Text Truncation
  1. API and functional correctness
  • check for console logs (warnings, errors)
  • API boundary values
  • different combinations of components - free style
  • change the API values during testing
  1. Documentation and Example validations
  • missing API documentation or it is not understandable
  • poor examples
  • Stackblitz works for all examples
  1. Accessibility testing
  2. Browser Testing - Edge, Safari, Chrome, Firefox
PR Quality

…nsity to handle all type of themes on demand.
@dpavlenishvili dpavlenishvili self-assigned this Sep 5, 2024
Copy link

netlify bot commented Sep 5, 2024

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit 17e8c41
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/66ec993cc9fc920008bce1d2
😎 Deploy Preview https://deploy-preview-12370--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Sep 5, 2024

Visit the preview URL for this PR (updated for commit 17e8c41):

https://fundamental-ngx-gh--pr12370-11368-no-way-to-set-g6znud2u.web.app

(expires Sun, 22 Sep 2024 21:42:06 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

@dpavlenishvili dpavlenishvili requested a review from a team September 5, 2024 15:44
@dpavlenishvili dpavlenishvili added the nice to have a nice to have feature/improvement label Sep 5, 2024
Copy link
Member

@mikerodonnell89 mikerodonnell89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment:

@droshev
Copy link
Contributor

droshev commented Sep 17, 2024

@mikerodonnell89 Can you check the latest changes?

@droshev
Copy link
Contributor

droshev commented Sep 19, 2024

@mikerodonnell89 Can you check the latest changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nice to have a nice to have feature/improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No way to set fdCozy to fd-dialog component on desktop viewport
4 participants