Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generator): write using utf-8 #1004

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

AmaseCocoa
Copy link

Change Summary

Changed to explicitly use utf-8 in packaged_schema.write_text to avoid UnicodeEncodeError that cp932 may cause in Japanese Windows environment.

Unit Test is currently under construction :)

Checklist

  • Unit tests for the changes exist
  • Tests pass without significant drop in coverage
  • Documentation reflects changes where applicable
  • Test snapshots have been updated if applicable

Agreement

By submitting this pull request, I confirm that you can use, modify, copy and redistribute this contribution, under the terms of your choice.

@AmaseCocoa
Copy link
Author

AmaseCocoa commented Aug 10, 2024

For some reason it seems to contain commit for pull request #1002 :( I forgot that I committed to main by mistake, it seems it has already been Revert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant