Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise access control expose header #280

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Revise access control expose header #280

wants to merge 3 commits into from

Conversation

bulk88
Copy link
Contributor

@bulk88 bulk88 commented Sep 30, 2020

see commit msgs

-Access-Control-Expose-Headers is only for what content response headers
 can be visible inside Javascript, nobody will do XHR preflight OPTIONS
 verb by hand, saves bytes on wire and undefined behaviour

-dont deref request.corsAnywhereRequestState.corsMaxAge unless value
 used

source

https://web.archive.org/web/20200110204952/https://www.html5rocks.com/static/images/cors_server_flowchart.png
-XHR code will not inspect the A-C-* values, it can't even get them with
 getResponseHeader() if their is a fault with A-C-* headers

moving "headers['access-control-allow-origin'] = '*';" to after
Expose-Headers computation keeps "access-control-allow-origin" out of
Expose-Headers value
@coveralls
Copy link

coveralls commented Sep 30, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling 455cdb6 on bulk88:revise_Access-Control-Expose-Header into 528ad71 on Rob--W:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants