-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated http-proxy dependency to ^1.15.2 #183
base: master
Are you sure you want to change the base?
Conversation
Fixes issue where cors-anywhere fails when used alongside browserify.
CORS Anywhere relies on (undocumented) internals of the Look for "1.11.1" at lib/cors-anywhere.js, verify that the logic still makes sense and replace "1.11.1" with the chosen value. A bunch of unit tests are also failing with this PR (see the results from Travis), they must pass before the PR can be merged. |
since cors-anywhere uses an old http-proxy version, it is impossible to use cors-anywhere and a modern http-proxy's "selfHandleResponse" flag to intercept and rewrite the steams if necessary no "selfHandleResponse" in that old version
I cooked this up to selectively rewrite HTML inside cors-anywhere but it took too long and its more class monkey method patching and it seems very fragile. Performance is poor in TTTB/etc if the HTML is rewritten, but its very rare in my use case (99% of HTTP reqs go through XHR to API endpoint, rarely a cloudflare captcha comes up and it must be manually solved by the user in an iframe and the XHR JSON POST repeated). |
I have the same issue. yarn resolutions feature helped to solve it.
|
Fixes #182