Skip to content

Commit

Permalink
Merge pull request #2671 from ROCm/r2.17-rocm-enhanced_navi_scrub
Browse files Browse the repository at this point in the history
Replace "Navi" with corresponding public product names
  • Loading branch information
ScXfjiang committed Sep 17, 2024
2 parents b4e2445 + ed2eec1 commit 64ba48a
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 7 deletions.
13 changes: 8 additions & 5 deletions third_party/xla/xla/stream_executor/device_description.h
Original file line number Diff line number Diff line change
Expand Up @@ -205,16 +205,19 @@ class RocmComputeCapability {
return absl::c_count(kList, gfx_version()) != 0;
}

bool navi21() const { return gfx_version() == "gfx1030"; }
bool gfx10_rx68xx() const { return gfx_version() == "gfx1030"; }

bool navi31() const { return gfx_version() == "gfx1100"; }
bool gfx10_rx69xx() const { return gfx_version() == "gfx1030"; }

bool gfx11_rx7900() const { return gfx_version() == "gfx1100"; }

bool has_nhwc_layout_support() const { return gfx9_mi100_or_later(); }

bool has_bf16_dtype_support() const { return gfx9_mi100_or_later(); }

bool has_fast_fp16_support() const {
return gfx9_mi100_or_later() || navi21() || navi31();
return gfx9_mi100_or_later() || gfx10_rx68xx() || gfx10_rx69xx() ||
gfx11_rx7900();
}

bool has_mfma_instr_support() const { return gfx9_mi100_or_later(); }
Expand Down Expand Up @@ -251,8 +254,8 @@ class RocmComputeCapability {
"gfx908", // MI100
"gfx90a", // MI200
"gfx940", "gfx941", "gfx942", // MI300
"gfx1030", // Navi21
"gfx1100" // Navi31
"gfx1030", // RX68xx / RX69xx
"gfx1100" // RX7900
};
};

Expand Down
8 changes: 6 additions & 2 deletions third_party/xla/xla/stream_executor/rocm/rocm_driver.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1998,12 +1998,16 @@ static absl::StatusOr<T> GetSimpleAttribute(hipDevice_t device,
const uint64_t RESERVED_GFX908 = 1048576 * 512;
const uint64_t RESERVED_GFX9_X = 1048576 * 1024;
const uint64_t RESERVED_GFX10_X = 1048576 * 512;
if (compute_capability.gfx_version() == "gfx908") {
const uint64_t RESERVED_GFX11_X = 1048576 * 512;
if (compute_capability.gfx9_mi100()) {
*reserve = RESERVED_GFX908;
} else if (compute_capability.gfx9_mi200_or_later()) {
*reserve = RESERVED_GFX9_X;
} else if (compute_capability.navi21() || compute_capability.navi31()) {
} else if (compute_capability.gfx10_rx68xx() ||
compute_capability.gfx10_rx69xx()) {
*reserve = RESERVED_GFX10_X;
} else if (compute_capability.gfx11_rx7900()) {
*reserve = RESERVED_GFX11_X;
}

return true;
Expand Down

0 comments on commit 64ba48a

Please sign in to comment.