-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(qwik-city): init Fastly adapter #5552
Conversation
- Added @fastly/js-compute and fastly.d.ts to root so API Extractor can be aware of types during generation - Added @fastly/js-compute and @fastly/compute-js-static-publish to qwik-city for use with adapter middleware
- middleware uses @fastly/compute-js-static-publish to handle inlining static assets into the WASM or publishing via Fastly KV Store
👷 Deploy request for qwik-insights pending review.Visit the deploys page to approve it
|
Thanks @kalebpace for this integration |
Thanks @gioboa! I'll give this a go soon.
Update: |
@kalebpace do you have any news for this PR? |
@gioboa thanks for checking-in. Unfortunately the Fastly runtime has a few APIs missing to fully cover the suite. I've outlined what is missing here: QwikDev/qwik-city-e2e#9 Waiting to get some feedback/suggestions on whether the adapter is acceptable in its current state, maybe tagged as experimental, or if I need to put this work on pause and coordinate with Fastly until APIs are implemented. Happy to hear any thoughts you might have on this! |
I think it's better to ship the feature only when is complete. This avoids unpleasant issues for missing features/bugs. |
Hi @kalebpace thanks for your help. |
It's likely invalid, good to close |
Overview
Hi everyone,
I've initialized a Qwik City adapter for Fastly's Compute@Edge platform based off the Cloudflare adapter. All code for the adapter and e2e usage lives here and is deployed here.
There is a decent amount of work still needed to bring the adapter and starter template up to speed for a proper dev server and production deployment. Though, wanted to open this PR early in the process to get feedback and advice on how best to integrate Fastly specific adapter needs (e.g. adding
fastly.d.ts
to the root Qwik project since@fastly/js-compute
only exposes types for virtual modules likefastly:env
).I have additional work here that is slightly older, but had the intention of opening a PR into the
@fastly/js-compute
project to address type issues when trying to import functions using static imports, otherwise dynamic imports are needed. Likely the next step to bringing the adapter up to speed.Thanks in advance for your time, look forward to hearing any feedback!
What is it?
Checklist: