Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[laffer_adaptive] [lake_model] spelling and check example admonition #545

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

longye-tian
Copy link
Collaborator

@longye-tian longye-tian commented Aug 7, 2024

Dear John @jstac and Matt @mmcky

This pull request is to update the spelling #532 and check the example admonition #520 for the lecture laffer_adaptive.md and lake_model.md. In particular:

[laffer_adaptive.md]:

  • change 'it reverse' to 'it reverses'
  • change the subtitle to lower case to match with the style
  • change 'pseudo code' to 'pseudo-code' to match with the title for consistency
  • change 'limiting values exists' to 'limiting values exist'
  • add hyphen to steady state when using is as adjective for consistency.

[lake_model.md]:

  • change 'the below graph' to 'the graph below' for better word ordering
  • change 'long run growth' to 'long-run growth' for consistency

There are no example admonitions that need to be added after reviewing these two lectures.

Best ❤️
Longye

- change 'it reverse' to 'it reverses'
- change the subtitle to lower case to match with the style
- change 'pseudo code' to 'pseudo-code' to match with the title for consistency
- change 'limiting values exists' to 'limiting values exist'

- add hyphen to steady state when using is as adjective for consistency.
Copy link

netlify bot commented Aug 7, 2024

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit 7713179
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/66b32d1e17d8de0008decb50
😎 Deploy Preview https://deploy-preview-545--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Aug 7, 2024

@github-actions github-actions bot temporarily deployed to pull request August 7, 2024 08:09 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 7, 2024 08:09 Inactive
- change 'the below graph' to 'the graph below' for better word ordering

- change 'long run growth' to 'long-run growth' for consistency
@longye-tian longye-tian changed the title [laffer_adaptive] update style and spelling [laffer_adaptive] [lake_model] update style and spelling and check example admonition Aug 7, 2024
@longye-tian longye-tian changed the title [laffer_adaptive] [lake_model] update style and spelling and check example admonition [laffer_adaptive] [lake_model] spelling and check example admonition Aug 7, 2024
@github-actions github-actions bot temporarily deployed to pull request August 7, 2024 08:22 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 7, 2024 08:23 Inactive
@longye-tian longye-tian marked this pull request as ready for review August 7, 2024 08:42
@longye-tian longye-tian requested review from jstac and mmcky August 7, 2024 08:43
@jstac
Copy link
Contributor

jstac commented Aug 7, 2024

Nice work @longye-tian , many thanks!

@jstac jstac merged commit 20a3b6c into main Aug 7, 2024
7 checks passed
@jstac jstac deleted the laffer_adaptive_spelling_example branch August 7, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants