Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Proof of concept for using PyO3 in cargo unit tests. #13169

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

kevinhartman
Copy link
Contributor

Summary

For now, this is mostly just a proof-of-concept. I'm making a non-draft PR to see how our CI setup works with this.

Details and comments

TBD.

@kevinhartman kevinhartman requested a review from a team as a code owner September 17, 2024 17:12
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core
  • @kevinhartman
  • @mtreinish

@coveralls
Copy link

coveralls commented Sep 17, 2024

Pull Request Test Coverage Report for Build 10912231140

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 28 of 30 (93.33%) changed or added relevant lines in 1 file are covered.
  • 381 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 88.81%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/circuit/src/dag_circuit.rs 28 30 93.33%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 94.02%
crates/qasm2/src/lex.rs 8 91.73%
crates/circuit/src/dag_circuit.rs 372 87.05%
Totals Coverage Status
Change from base Build 10892476121: -0.1%
Covered Lines: 73467
Relevant Lines: 82724

💛 - Coveralls

@jakelishman
Copy link
Member

If you enable the pyo3/auto-initialize feature during the test-suite build, then the pyo3::prepare_freethreaded_python calls won't be necessary. Don't know if you had other work around the test harness planned, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants