Skip to content

Commit

Permalink
Fix ray timeout (#1425)
Browse files Browse the repository at this point in the history
* Fix dockerfile dependencies

* Raise an error if cluster is not ready

* Update version to 0.14.1

* Helm dependency update
  • Loading branch information
Tansito committed Jul 29, 2024
1 parent fbc8297 commit 211cb38
Show file tree
Hide file tree
Showing 14 changed files with 28 additions and 26 deletions.
6 changes: 3 additions & 3 deletions charts/qiskit-serverless/Chart.lock
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
dependencies:
- name: gateway
repository: ""
version: 0.14.0
version: 0.14.1
- name: nginx-ingress-controller
repository: https://charts.bitnami.com/bitnami
version: 9.11.0
Expand All @@ -11,5 +11,5 @@ dependencies:
- name: kuberay-operator
repository: https://ray-project.github.io/kuberay-helm
version: 1.1.1
digest: sha256:21bc630a23c9ba56029944e630208ceeb81191e064e004fe4fee91e4b496cfef
generated: "2024-07-17T21:37:54.223878815Z"
digest: sha256:43d30e0ff94d7453702f4de3d1efc3eea782d3ec45d7594c560e3e6d3675aa76
generated: "2024-07-29T11:10:24.552213-04:00"
6 changes: 3 additions & 3 deletions charts/qiskit-serverless/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@ description: Qiskit-Serverless helm chart that contains different dependencies.

type: application

version: 0.14.0
appVersion: "0.14.0"
version: 0.14.1
appVersion: "0.14.1"

dependencies:
- name: gateway
condition: gatewayEnable
version: 0.14.0
version: 0.14.1
- name: nginx-ingress-controller
condition: nginxIngressControllerEnable
version: 9.11.0
Expand Down
4 changes: 2 additions & 2 deletions charts/qiskit-serverless/charts/gateway/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.14.0
version: 0.14.1

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
# It is recommended to use it with quotes.
appVersion: "0.14.0"
appVersion: "0.14.1"
6 changes: 3 additions & 3 deletions charts/qiskit-serverless/charts/gateway/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ application:
superuser:
enable: true
ray:
nodeImage: "icr.io/quantum-public/qiskit-serverless/ray-node:0.14.0-py39"
nodeImage_py39: "icr.io/quantum-public/qiskit-serverless/ray-node:0.14.0-py39"
nodeImage_py310: "icr.io/quantum-public/qiskit-serverless/ray-node:0.14.0-py310"
nodeImage: "icr.io/quantum-public/qiskit-serverless/ray-node:0.14.1-py39"
nodeImage_py39: "icr.io/quantum-public/qiskit-serverless/ray-node:0.14.1-py39"
nodeImage_py310: "icr.io/quantum-public/qiskit-serverless/ray-node:0.14.1-py310"
cpu: 2
memory: 2
replicas: 1
Expand Down
6 changes: 3 additions & 3 deletions charts/qiskit-serverless/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Qiskit Serverless Info
# ===================
global:
version: 0.14.0
version: 0.14.1

# ===================
# Qiskit Serverless configs
Expand Down Expand Up @@ -47,7 +47,7 @@ gateway:
image:
repository: "icr.io/quantum-public/qiskit-serverless/gateway"
pullPolicy: IfNotPresent
tag: "0.14.0"
tag: "0.14.1"
application:
siteHost: "http://gateway:8000"
rayHost: "http://kuberay-head-svc:8265"
Expand All @@ -59,7 +59,7 @@ gateway:
type: ClusterIP
port: 8000
ray:
nodeImage: "icr.io/quantum-public/qiskit-serverless/ray-node:0.14.0-py310"
nodeImage: "icr.io/quantum-public/qiskit-serverless/ray-node:0.14.1-py310"
opensslImage: registry.access.redhat.com/ubi8/openssl:8.8-9
kubectlImage: alpine/k8s:1.29.2@sha256:a51aa37f0a34ff827c7f2f9cb7f6fbb8f0e290fa625341be14c2fcc4b1880f60
limits:
Expand Down
2 changes: 1 addition & 1 deletion client/qiskit_serverless/VERSION.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.14.0
0.14.1
6 changes: 3 additions & 3 deletions docker-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
services:
ray-head:
container_name: ray-head
image: icr.io/quantum-public/qiskit-serverless/ray-node:${VERSION:-0.14.0}-py310
image: icr.io/quantum-public/qiskit-serverless/ray-node:${VERSION:-0.14.1}-py310
entrypoint: [
"ray", "start", "--head", "--port=6379",
"--dashboard-host=0.0.0.0", "--block"
Expand All @@ -27,7 +27,7 @@ services:
always
gateway:
container_name: gateway
image: icr.io/quantum-public/qiskit-serverless/gateway:${VERSION:-0.14.0}
image: icr.io/quantum-public/qiskit-serverless/gateway:${VERSION:-0.14.1}
command: gunicorn main.wsgi:application --bind 0.0.0.0:8000 --workers=4
ports:
- 8000:8000
Expand All @@ -52,7 +52,7 @@ services:
- postgres
scheduler:
container_name: scheduler
image: icr.io/quantum-public/qiskit-serverless/gateway:${VERSION:-0.14.0}
image: icr.io/quantum-public/qiskit-serverless/gateway:${VERSION:-0.14.1}
entrypoint: "./scripts/scheduler.sh"
environment:
- DEBUG=0
Expand Down
4 changes: 2 additions & 2 deletions docs/deployment/cloud.rst
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ Once your cluster is ready, the installation is relatively straightforward with
and run the next commands:

.. code-block::
:caption: run this commands with the release version like 0.14.0 in x.y.z (2 places)
:caption: run this commands with the release version like 0.14.1 in x.y.z (2 places)
$ helm -n <INSERT_YOUR_NAMESPACE> install qiskit-serverless --create-namespace https://github.com/Qiskit/qiskit-serverless/releases/download/vx.y.z/qiskit-serverless-x.y.z.tgz
Expand Down Expand Up @@ -119,6 +119,6 @@ with the configuration of your domain and provider.
Optionally, you can install an observability package to handle logging and monitoring on your cluster by running the following command:

.. code-block::
:caption: run this commands with the release version like 0.14.0 in x.y.z (2 places) using the same namespace as in the previous helm command
:caption: run this commands with the release version like 0.14.1 in x.y.z (2 places) using the same namespace as in the previous helm command
$ helm -n <INSERT_YOUR_NAMESPACE> install qs-observability https://github.com/Qiskit/qiskit-serverless/releases/download/vx.y.z/qs-observability-x.y.z.tgz
2 changes: 1 addition & 1 deletion docs/deployment/custom_function/Sample-Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM icr.io/quantum-public/qiskit-serverless/ray-node:0.14.0-py310
FROM icr.io/quantum-public/qiskit-serverless/ray-node:0.14.1-py310

# install all necessary dependencies for your custom image

Expand Down
2 changes: 1 addition & 1 deletion docs/deployment/deploying_custom_image_function.rst
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ In our simple case it will look something like this:
.. code-block::
:caption: Dockerfile for custom image function.
FROM icr.io/quantum-public/qiskit-serverless/ray-node:0.14.0-py310
FROM icr.io/quantum-public/qiskit-serverless/ray-node:0.14.1-py310
# install all necessary dependencies for your custom image
Expand Down
2 changes: 1 addition & 1 deletion docs/deployment/example_custom_image_function.rst
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ Dockerfile
.. code-block::
:caption: Dockerfile
FROM icr.io/quantum-public/qiskit-serverless/ray-node:0.14.0-py310
FROM icr.io/quantum-public/qiskit-serverless/ray-node:0.14.1-py310
# install all necessary dependencies for your custom image
Expand Down
2 changes: 1 addition & 1 deletion gateway/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
FROM registry.access.redhat.com/ubi9-minimal:9.4-1134
RUN microdnf install -y python3.11-3.11.7-1.el9_4.1 python3.11-pip-22.3.1-5.el9 python3.11-devel-3.11.7-1.el9_4.1 vim-enhanced-2:8.2.2637-20.el9_1 &&\
RUN microdnf install -y python3.11-3.11.7 python3.11-pip-22.3.1 python3.11-devel-3.11.7 vim-enhanced-8.2.2637 &&\
microdnf clean all
RUN ln -s /usr/bin/python3.11 /usr/local/bin/python3 && \
ln -s /usr/bin/python3.11 /usr/local/bin/python &&\
Expand Down
4 changes: 3 additions & 1 deletion gateway/api/ray.py
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ def submit_job(job: Job) -> Job:
return job


def create_ray_cluster(
def create_ray_cluster( # pylint: disable=too-many-branches
job: Job,
cluster_name: Optional[str] = None,
cluster_data: Optional[str] = None,
Expand Down Expand Up @@ -289,6 +289,8 @@ def create_ray_cluster(
resource.title = cluster_name
resource.host = host
resource.save()
else:
raise RuntimeError("Something went wrong during cluster creation")
return resource


Expand Down
2 changes: 1 addition & 1 deletion gateway/main/settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@
),
}
RAY_NODE_IMAGE = os.environ.get(
"RAY_NODE_IMAGE", "icr.io/quantum-public/qiskit-serverless/ray-node:0.14.0-py310"
"RAY_NODE_IMAGE", "icr.io/quantum-public/qiskit-serverless/ray-node:0.14.1-py310"
)
RAY_NODE_IMAGES_MAP = {
"default": RAY_NODE_IMAGE,
Expand Down

0 comments on commit 211cb38

Please sign in to comment.