Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #274] Add the new required text fields (December 2015 release of the materi… #371

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MeTaNoV
Copy link
Contributor

@MeTaNoV MeTaNoV commented Mar 26, 2016

Fixes #274 :
Add the new required text fields (December 2015 release of the material design spec)

@@ -83,6 +83,7 @@
`--paper-input-container-color` | Label and underline color when the input is not focused | `--secondary-text-color`
`--paper-input-container-focus-color` | Label and underline color when the input is focused | `--primary-color`
`--paper-input-container-invalid-color` | Label and underline color when the input is is invalid | `--error-color`
`--paper-input-container-required-color` | Color used for the asterix displayed for required input | `--error-color`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure there's a need for this. From the mocks, the * is the same color as the error color, and I don't think there's a need for that to be different.

@MeTaNoV
Copy link
Contributor Author

MeTaNoV commented Mar 29, 2016

@notwaldorf I took into account your remark and squashed the commit!

@MeTaNoV
Copy link
Contributor Author

MeTaNoV commented Apr 14, 2016

@notwaldorf friendly ping! :)

@florent1933
Copy link

I love this PR. Good job @MeTaNoV 👍

@MeTaNoV
Copy link
Contributor Author

MeTaNoV commented Oct 21, 2016

Thx @florent1933 , somehow get lost... @notwaldorf is paper-input still under focus?

@florent1933
Copy link

Maybe not...

@notwaldorf
Copy link
Contributor

notwaldorf commented Dec 19, 2016

paper-input is still under focus, but this PR can't be merged because it needs a rebase. Secondly, in its current form, I am not super convinced it's not a breaking change to the 1.0 version, so I'm not sure it can even be merged in 1.0

@MeTaNoV
Copy link
Contributor Author

MeTaNoV commented Dec 19, 2016

@notwaldorf this means I have to work a bit for Polymer Team? I have busy with Machine Learning @ Google right now.... Next week, maybe... Thanks for the follow-up BTW!!

@MeTaNoV
Copy link
Contributor Author

MeTaNoV commented Mar 10, 2017

@notwaldorf shall I rebase for 2.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants