Add in some more messages to PMStatisticalSample #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add in a test to make sure that passing in a negative number causes an error.
* Add in guard clause to prevent use with negative numbers as the behaviour is not well defined. * Prevent a potential float under/overflow by summing the logarithms as suggested by Nicolas Cellier.
…ion. Adds in average, mean, median, stdev, variance messages
… stat-functions
hemalvarambhia
previously approved these changes
Apr 16, 2021
| @@ -49,6 +49,20 @@ PMStatisticalSample class >> harmonicMean: aCollection [ | |||
| ^ (self newFrom: aCollection) harmonicMean | |||
| ] | |||
|
|
|||
| { #category : #information } | |||
| PMStatisticalSample class >> mean: aCollection [ | |||
There was a problem hiding this comment.
maybe aCollection could be aSample
There was a problem hiding this comment.
ok, I changed from aCollection to aSample
| ] | ||
|
|
||
| { #category : #information } | ||
| PMStatisticalSample class >> median: aCollection [ |
There was a problem hiding this comment.
Same as above - aCollection -> aSample
hemalvarambhia
approved these changes
Apr 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I have fleshed out the
PMStatisticalSampleobject created in #186. This pull request adds in average, mean, median, stdev, variance messages to try to address #187Best,
Connor