Custom analog error rate #1136
Open
Custom analog error rate #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functionally working, web is broken in the following ways: 1 - Error Rate title shows regardless of Forced Circularity being checked, but the selection box hides as expected 2 - Selecting a value saves, but when reloading the webpage there is an error and it thinks it's set to 0%
Improve formSelect to handle hidden prop
|
After saving with the value |
Pelsin
reviewed
Sep 16, 2024
headers/addons/analog.h
Outdated
| @@ -69,6 +69,10 @@ | |||
| #define SMOOTHING_FACTOR 5 | |||
| #endif | |||
|
|
|||
| #ifndef ANALOG_ERROR | |||
| #define ANALOG_ERROR 0 | |||
There was a problem hiding this comment.
If the default value is zero we need to modify form validation
As zero does not exist as any value here: https://github.com/OpenStickCommunity/GP2040-CE/pull/1136/files#diff-1dc51191c1aed5b94ed7849f6d8458038a17ed0c47da979dd4de7e7adc3a8c99R25
Otherwise we will get the error:
When toggling the switch the first time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to set a custom circularity error rate % for analog sticks.