Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FIFA World Cup history #7

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add FIFA World Cup history #7

wants to merge 4 commits into from

Conversation

guillemontecinos
Copy link

World Cup statistics added by creating world_cup_history.json entry within the sports/football directory. This PR requires to merge the corpora fork I created in my account to OSS's corpora fork.

Copy link
Member

@shiffman shiffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚽️🌍⚽️🌏⚽️🌎

data/sports/football/world_cup_history.json Outdated Show resolved Hide resolved
data/sports/football/world_cup_history.json Outdated Show resolved Hide resolved
data/sports/football/world_cup_history.json Outdated Show resolved Hide resolved
@guillemontecinos
Copy link
Author

I solved changes requested, please let me know if some thing else is needed.
Best!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants