Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add agi designers list #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add agi designers list #11

wants to merge 1 commit into from

Conversation

vince19972
Copy link
Member

No description provided.

Copy link
Member

@shiffman shiffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Some small suggestions / fixes!

@@ -0,0 +1,715 @@
[
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the standard format for corpora is to start with an object and then include the list as a named array. The objects generally also include "description" and "source" properties:

{
    "description": "____________",
    "source": "____________",
    "designers": [ ]
}

"Martin Venezky",
"Martin Woodtli",
"Martti Mykk\u00e4nen",
"Masaaki Hiromura"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing comma! 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!! Sorry I didn't check it carefully and even not aware of the result from CI testings 😭

"Yung-Chen Nieh",
"Adrian Frutiger",
"Adrian Shaughnessy",
"Aimo Katajam\u00e4ki",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the file is UTF-8 encoded, this could be "Aimo Katajamäki" rather than escaping characters. (Same below for others with \uXXXX values.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants