Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no error statuses for failed requests (#18) #21

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mwelwankuta
Copy link

No description provided.

@vercel
Copy link

vercel bot commented Jan 31, 2023

@mwelwankuta is attempting to deploy a commit to the Vercel Labs Team on Vercel.

A member of the Team first needs to authorize it.

res
.status(200)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The client checks the status of the request before rendering the restored image, when the JSON message is "Failed to restore image" while the status is 200, the client tries to render an image with the url of "Failed%20to%20restore%20image" returning a different status code fixes the issue from #18

@vercel
Copy link

vercel bot commented Feb 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
restore-photos ❌ Failed (Inspect) Feb 4, 2023 at 4:31AM (UTC)

@Nutlope
Copy link
Owner

Nutlope commented Feb 4, 2023

@mwelwankuta Thanks for the PR! Mind fixing this error on the deployment?
CleanShot 2023-02-03 at 23 32 26@2x

@mwelwankuta
Copy link
Author

alright working on it

@mwelwankuta
Copy link
Author

@Nutlope i have resolved the issue and pushed the code. you can now test it out.

@mwelwankuta mwelwankuta changed the title Fix for #18 fix: no error statuses for failed requests (#18) Feb 4, 2023
@mwelwankuta
Copy link
Author

you can look at the deployment

@mwelwankuta
Copy link
Author

Hey is this pr still open @Nutlope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants