-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corpus module #13
Corpus module #13
Conversation
Failing tests. I would check this and fix them as soon as I can. |
Hi @Olamyy ! Thank you very much for your PR and overall contributions!! These look like useful additions to the library! Overall, I think it might be more collaborative to discuss, design & review proposed changes before we get to the PR phase (where we're just battling Travis issues), especially to ensure that we are synchronized on goals & to get opinions like from David, Timi and others. What do you think of this approach? Regarding the build failure, it is perhaps because you need to add an |
Yeah. That definitely seems like a better and more organized approach to working on features. Which of github or slack do you think would be a good medium for this? About the failing tests, I came about this same link while trying to figure out what the issue was. I just haven't looked at it in details yet. I'll get to it as soon as I can. Thanks. |
Great! Let me make a Project board and some milestones and you can add some cards, so basically github. This way the work can stay localized to the project, even if we have a higher reliance on github. Maybe I'll take a fork of your fork and see if the |
The new project is here: https://github.com/Niger-Volta-LTI/iranlowo/projects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay, will try it out once changes are merged and tweak anything. The only question I have is whether you ran the Black code formatter? https://black.readthedocs.io/en/stable/
I've been using this and liking it a lot, so have been using it to to keep my codes presentable. I should probably figure out how to add it to the linting system within Travis ... 🤔
Introduces a number of changes:
Restructured the file structure by:
Converted existing tests to unittest. Major win here is that the tests are now in reusable OOP format.
Introduces some of the enhancements in Corpus Loading Features #12 :