Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't lose the BMP msg when querying its common header properties. #37

Closed
wants to merge 81 commits into from
Closed

Don't lose the BMP msg when querying its common header properties. #37

wants to merge 81 commits into from

Conversation

ximon18
Copy link
Member

@ximon18 ximon18 commented Oct 4, 2023

And replaces some TABs with spaces to make the indentation consistent with nearby fns.

DRiKE added 30 commits May 17, 2023 15:24
@DRiKE
UpdateBuilder wip
962136f
@DRiKE
Add AttrChangeSet::empty() constructor
138d5ce
@DRiKE
WIP building from AttrChangeSet, AsPath works
18a0958
@DRiKE
Use typeenum! for OriginType (ORIGIN path attribute)
bcb4fb3
@DRiKE
Building OriginType from AttrChangeSet works
11b3d86
@DRiKE
and NEXT_HOP
4393e5c
@DRiKE
and a single v4/unicast conventional NLRI
bcc5f2a
@DRiKE
and Standard Communities
bd31dd6
@DRiKE
and ADDPATH PathId in NLRI
2c87f7f
@DRiKE
Clippy
22c478b
@DRiKE
Introduce ComposeError, possibly returned from build_acs
706742f
@DRiKE
Remove println
4340a47
@DRiKE
Merge branch 'main' into compose-messages
313c798
@DRiKE
Implement compose for BasicNlri
051f538
@DRiKE
WIP UpdateBuilder
a3b7d98
@DRiKE
Add fn compose and helpers for Nlri
7da094c
@DRiKE
WIP UpdateBuilder error form add_withdrawals when exceeding max PDU size
0141421
@DRiKE
WIP UpdateBuilder use Header struct in fn finish
317289c
@DRiKE
Do not return number of bytes from Nlri.compose()
995ad22
@DRiKE
WIP UpdateBuilder more and better errors
f618b80
@DRiKE
WIP UpdateBuilder.withdrawals_from_iter() for Peekable
670ff69
@DRiKE
Introduce MpUnreachNlriBuilder
0aba695
@DRiKE
Track and check for ADDPATH in withdrawals / MpUnreachNlri
0ebafe8
@DRiKE
Clippy
4579710
@DRiKE
Notes and musings on how NLRI should be handled better
7ca9e3a
@DRiKE
Introduce Nlri::Unicast/Multicast to replace Nlri::Basic
038f972 
The `Nlri::Basic` enum variant was used to carry both unicast and
multicast SAFI NLRI. Replacing the `Basic` variant with explicit
`Unicast` and `Multicast` variants is less error-prone for the user.
Additionally, this commit removes methods from `Nlri` that hid similar
details, e.g. the `prefix()` allowed the user to extract the prefix
without knowing the exact variant of `Nlri`, so a user might unknowingly
be looking at and using a prefix coming from a MplsVpn NLRI for example
while they are actually only interested in say, unicast announcements.
@DRiKE
UpdateBuilder: support for conventional nlri, ORIGIN, AS_PATH, NEXTHOP
14d69c9
@DRiKE
Clippy
b2a5563
@DRiKE
Adapt test to new Nlri API
f1416bc
@DRiKE
First limited version of MpReachNlriBuilder
d693fd7
DRiKE and others added 23 commits August 29, 2023 18:32
@DRiKE
Clippy
b36e03c
@DRiKE
Add Invalid variant for PathAttributes
5efa8f3
@DRiKE
Fix As4Aggregator test
c62a228
@DRiKE
Implement fn validate for all path attributes
11e99c1
@DRiKE
Add Ipv6ExtendedCommunities
1a292af
@DRiKE
Add AttrSet (128) and Reserved (255) path attributes
c1f6d6c
@DRiKE
Get rid of some unwraps
348b2b0
@DRiKE
Impl Deref(Mut) for wrapped data of owned PathAttribute variants
850130a
@DRiKE
Impl AsRef/AsMut instead of Deref(Mut)
7c58438
@DRiKE
Move new PathAttribute and friends into bgp::path_attributes
1ea6361
@DRiKE
Move new PathAttribute, part deux: The unsaved vim buffers
6e3909b
@DRiKE
WIP UpdateBuilder::from_update_message
5313943
@DRiKE
Keep track of arbitrary PathAttributesin a BTreeMap in UpdateBuilder
c4d8869
@DRiKE
Use StandardCommunitiesBuilder in UpdateBuilder
4967daf
@DRiKE
Move conventional NEXT_HOP into UpdateBuilder.attributes
d2083fd
@DRiKE
Move MpUnreachNlriBuilder into UpdateBuilder.attributes
da72758
@DRiKE
Remove unused mp_unreach_nlri_builder field from UpdateBuilder
066a08d
@DRiKE
Move MpReachNlriBuilder into UpdateBuilder.attributes
ae3d7de
@DRiKE
Clean up obsolete compose/compose_len on Mp*NlriBuilder
14c4471
@DRiKE
Clean up, comments
94d83cf
@DRiKE
Make UpdateBuilder::from_update_message actually Error on invalid att…
35064ca 
…ributes
@DRiKE
More clean up, comments
dcc7f0d
@ximon18
Don't lose the BMP msg when querying its common header properties.
16370a4 
And replaces some TABs with spaces to make the indentation consistent with nearby fns.
@ximon18 ximon18 requested a review from DRiKE October 4, 2023 14:41
@ximon18 ximon18 changed the base branch from compose-messages-nlri-v2 to main October 5, 2023 07:54
@ximon18
Copy link
Member Author

ximon18 commented Oct 5, 2023

Will re-apply to main and resubmit.

@ximon18 ximon18 closed this Oct 5, 2023
@ximon18 ximon18 deleted the take-self-by-ref-in-bmp-common-header-fns branch October 5, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DRiKE DRiKE Awaiting requested review from DRiKE

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ximon18 @DRiKE