Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/update get top profitable wallet per token return object #1222

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

gabkk
Copy link
Collaborator

@gabkk gabkk commented Jul 12, 2024


name: 'Pull request'
about: A new pull request

New Pull Request

Checklist

  • I am not disclosing a vulnerability.
  • My code is conform the code style
  • I have made corresponding changes to the documentation
  • I have updated Typescript definitions when needed

Issue Description

getTopProfitableWalletPerToken return token metadata in each wallet which is redondant

Solution Description

getTopProfitableWalletPerToken
Move token metadata at the top level, rename wallets for result , and remove token redondant information

@gabkk gabkk requested a review from a team as a code owner July 12, 2024 09:05
Copy link

changeset-bot bot commented Jul 12, 2024

🦋 Changeset detected

Latest commit: 9183076

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@moralisweb3/common-evm-utils Patch
@moralisweb3/evm-api Patch
moralis Patch
@moralisweb3/api-generator Patch
@moralisweb3/api-utils Patch
@moralisweb3/aptos-api Patch
@moralisweb3/auth Patch
@moralisweb3/codegen Patch
@moralisweb3/evm-utils Patch
@moralisweb3/next Patch
@moralisweb3/parse-server Patch
@moralisweb3/react Patch
@moralisweb3/sol-api Patch
@moralisweb3/sol-utils Patch
@moralisweb3/streams Patch
@moralisweb3/test-utils Patch
@moralisweb3/common-aptos-utils Patch
@moralisweb3/common-auth-utils Patch
@moralisweb3/common-core Patch
@moralisweb3/common-sol-utils Patch
@moralisweb3/common-streams-utils Patch
@moralisweb3/client-api-utils Patch
@moralisweb3/client-evm-api Patch
@moralisweb3/client-firebase-api-utils Patch
@moralisweb3/client-firebase-auth-utils Patch
@moralisweb3/client-firebase-evm-api Patch
@moralisweb3/client-firebase-evm-auth Patch
@moralisweb3/client-firebase-sol-api Patch
@moralisweb3/client-firebase-sol-auth Patch
@moralisweb3/client-sol-api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Test coverage

Title Lines Statements Branches Functions
api-utils Coverage: 20%
20.6% (61/296) 20.48% (17/83) 19.04% (12/63)
auth Coverage: 89%
92.45% (98/106) 83.33% (20/24) 86.66% (26/30)
evm-api Coverage: 76%
78.26% (90/115) 66.66% (6/9) 69.13% (56/81)
common-aptos-utils Coverage: 4%
4.56% (151/3306) 4.49% (25/556) 5.53% (45/813)
common-evm-utils Coverage: 54%
55.37% (2210/3991) 16.19% (172/1062) 36.45% (487/1336)
sol-api Coverage: 97%
97.56% (40/41) 66.66% (6/9) 93.75% (15/16)
common-sol-utils Coverage: 64%
65.42% (229/350) 41.86% (18/43) 50.89% (57/112)
common-streams-utils Coverage: 90%
90.73% (1204/1327) 73.63% (363/493) 82.07% (444/541)
streams Coverage: 91%
90.54% (603/666) 72.34% (68/94) 90.97% (131/144)

@b4rtaz b4rtaz merged commit 7b334bf into main Jul 12, 2024
6 checks passed
@b4rtaz b4rtaz deleted the feat/update-getTopProfitableWalletPerToken-return-object branch July 12, 2024 09:19
@github-actions github-actions bot mentioned this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants