Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mol descriptors #304

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Mol descriptors #304

wants to merge 16 commits into from

Conversation

dr-marsmm
Copy link

Description

Changelog description

Add MolecularDescriptors class with descriptors as attributes for descriptor attribute in AtomicResultProperties

Status

  • Code base linted
  • Ready to go

dr-marsmm and others added 16 commits January 26, 2023 11:07
…3.7.

Updated CONTRIBUTING.md to contain detailed instructions for developers on how to contribute.

Fixed broken code that failed to prepend the "v" to version numbers.

Updated CI to run without conda and using only packages defined in setup.py. CI is now much faster and runs the same way for local developers and GitHub Actions.

Added test.sh and format.sh to devtools/scripts for easy execution of formatting and testing.

Formatted all code with black. Sorted imports with isort.

Added pre-commit to repo so code formatting, linting, and testing will all run as part of regular git workflow.
…efined package dependencies.

Removed --validate tests.

Added scripts/build_docs.sh and removed Makefile for /docs. Flattened docs directory.

Removed setup.py in favor of pyproject.toml and poetry build system.

Removed LGTM and travis-ci code.
* Make sure extras is initialized as dict for Molecule

* Apply reformatting with black
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #304 (aa3dce3) into master (292350f) will decrease coverage by 4.72%.
The diff coverage is 94.33%.

Additional details and impacted files

@loriab
Copy link
Collaborator

loriab commented Aug 12, 2024

Are these rdkit-specific?

I'm thinking they're a little too specific for the general molecule class. Have you reconsidered since first opening the PR, or would they still be useful, @dr-marsmm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants