Fix MegaCoreX library to support ArduinoModBus and ArduinoRS485 #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #192 .
Arduino's modbus library is written assuming that the ArduinoCore-API is new enough that there is an arduino namespace. The version inside MegaCoreX is an older version of the api and does not have this. This pull request adds the minimal number of classes in the api to the arduino namespace to allow ArduinoModbus to compile.
The second change is related, the ArduinoRS485 library is written with the assumption that the macro SERIAL_PORT_HARDWARE is available from the board's variant header. This assumption was violated for the standard 28/32/40/48 pin variants. This pull request introduces these missing macros for libraries such as ArduinoRS485 so that they can compile successfully. I tried using what I viewed as sane defaults.