Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Added DE119-XX-XX from DE152-XX-XX (copy) #2424

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

valerionew
Copy link
Contributor

@valerionew valerionew commented Aug 26, 2020

Same as #2423 but for DE119. Symbol PR: KiCad/kicad-symbols#2936

The footprint is the same, the symbol changes by 1 pin

DS: https://www.display-elektronik.de/filter/DE119-RS-20_635.pdf
image


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing a dimensioned drawing of your contribution. A tutorial on how to do that is found here: https://forum.kicad.info/t/how-to-check-footprint-correctness/9279 (This is optional!)

@myfreescalewebpage myfreescalewebpage added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Aug 26, 2020
@myfreescalewebpage myfreescalewebpage self-assigned this Sep 9, 2020
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Sep 9, 2020
@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Sep 9, 2020

Thanks @valerionew

One comment (also applies to DE152):

Else looks good.
Joel

@valerionew valerionew force-pushed the LCD-DE119 branch 2 times, most recently from bc1486b to efabd0d Compare September 16, 2020 07:12
@valerionew
Copy link
Contributor Author

Fixed

image

@myfreescalewebpage
Copy link
Collaborator

Hello @valerionew I still not agree, I have 3.058mm actually.... Something wrong with the force push ?

@valerionew
Copy link
Contributor Author

It must have been a silly mistake on my side, please check if everything is in order now

@myfreescalewebpage
Copy link
Collaborator

It's better.

  • Length of the display area currently 44.448 instead of 44.45

Else looks good
Joel

@myfreescalewebpage
Copy link
Collaborator

@valerionew ping

@myfreescalewebpage
Copy link
Collaborator

No news of the author, indicate this is Abandoned

@myfreescalewebpage myfreescalewebpage added Abandoned Original author has stopped working on the PR and removed Abandoned Original author has stopped working on the PR labels Sep 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants