Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#94 - Symbolic interval matrix power type #121

Merged
merged 2 commits into from
Feb 8, 2020
Merged

#94 - Symbolic interval matrix power type #121

merged 2 commits into from
Feb 8, 2020

Conversation

schillic
Copy link
Member

@schillic schillic commented Feb 7, 2020

This is the first implementation for #94. More changes can be added later.

@schillic schillic requested a review from mforets February 7, 2020 20:40
Copy link
Member

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from the minor comments.

Tests are missing but we can also add this as follow-up.

src/power.jl Outdated Show resolved Hide resolved
src/power.jl Show resolved Hide resolved
src/power.jl Outdated Show resolved Hide resolved
src/power.jl Outdated Show resolved Hide resolved
src/power.jl Show resolved Hide resolved
@schillic
Copy link
Member Author

schillic commented Feb 7, 2020

Tests are missing but we can also add this as follow-up.

There are doctests. I could not think of other things that should be tested.

@schillic schillic requested a review from mforets February 7, 2020 21:00
@schillic schillic merged commit 091ab49 into master Feb 8, 2020
@schillic schillic deleted the schillic/94 branch February 8, 2020 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants