This repository has been archived by the owner on Jun 1, 2024. It is now read-only.
Add Melody Viewer Component #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use new melody viewer component in exploratory create
hcientist
suggested changes
Mar 6, 2024
components/student/create/aural.js
Outdated
| /> | ||
| </Col> | ||
| </Row> | ||
| )} | ||
| {/* TODO: if the student has already submitted this, do we show their submission here? if so how would they start over? */} | ||
| <FlatEditor |
There was a problem hiding this comment.
Probably you should move this FlatEditor inside the jsonh condition along with the 3 chordscalebucketscores?
components/flatMelodyViewer.js
Outdated
| onLoad, | ||
| debugMsg | ||
| }) { | ||
| const [embed, setEmbed] = useState(); |
There was a problem hiding this comment.
shouldn't this be a case of useRef?
components/flatMelodyViewer.js
Outdated
Comment on lines
30
to
75
| useEffect(() => { | ||
| const allParams = { | ||
| height: `${height}`, | ||
| width: width, | ||
| embedParams, | ||
| }; | ||
| setEmbed(new Embed(editorRef.current, allParams)); | ||
| }, [height]); | ||
|
|
||
| useEffect(() => { | ||
| if (!embed) return; | ||
| const loadParams = { | ||
| score: score.scoreId, | ||
| }; | ||
| if (score.sharingKey) { | ||
| loadParams.sharingKey = score.sharingKey; | ||
| } | ||
| embed | ||
| .ready() | ||
| .then( | ||
| () => | ||
| embed | ||
| .loadFlatScore(loadParams) | ||
| .then(() => { | ||
| embed | ||
| .getJSON() | ||
| .then( | ||
| (jsonData) => onLoad && onLoad(JSON.stringify(jsonData)) | ||
| ); | ||
| }) | ||
| .catch((e) => { | ||
| if (e && e.message) { | ||
| e.message = `flat error: ${e?.message}, not loaded from scoreId, score: ${JSON.stringify(score)}`; | ||
| if (debugMsg){ | ||
| e.message = `${e?.message}, debugMsg: ${debugMsg}`; | ||
| } | ||
| } else if(debugMsg) { | ||
| console.error('debugMsg', debugMsg); | ||
| if (score){console.error('score', score);} | ||
| } | ||
| console.error('score not loaded from scoreId'); | ||
| console.error('score', score); | ||
| throw e; | ||
| }) | ||
| ); | ||
| }, [embed]); |
There was a problem hiding this comment.
I know you didn't come up with this, but are just trying to survive my past code crimes, but it seems like there's really never a case for either of these 2 embeds to be run independently of the other.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add component specifically for loading the melody with no extra features. Replace the usage of FlatEditor with this new component in aural, exploratory, and theoretical. Some of the components on those pages attempted to load at the same time as the old FlatEditor even though they depended on the FlatEditors output. I added a conditional to only render them if the melody has been loaded.