This repository has been archived by the owner on Jun 1, 2024. It is now read-only.
rest shifting according to clarified spec #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcientist
reviewed
Feb 12, 2024
| @@ -647,14 +647,18 @@ function FlatEditor({ | |||
| setRefId(score.scoreId); | |||
| }) | |||
| .catch((e) => { | |||
| e.message = `flat error: ${e.message}, not loaded from scoreId, score: ${JSON.stringify(score)}, orig: ${orig}, colors: ${colors}`; | |||
| if (debugMsg){ | |||
There was a problem hiding this comment.
ok, but like, can you still keep debugMsg when it's available at least in the console error. the point of the hasty change was to be able to distinguish which instances of the Flateditor are experiencing the errors?
There was a problem hiding this comment.
Admittedly, my commenting out was hasty, especially considering the latter of the runtime errors seems to only happen when the scores lock. uncommented now
hcientist
suggested changes
Feb 12, 2024
per review request
only debugMsg and console.error
just debugMsg
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should take care of rests breaking the shifts.
notes will now have an
isRestproperty if they are part of a measure passed through these functions. Makes life easier.