Correct calculation for fullscreen window #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javifernandez
approved these changes
Aug 20, 2024
| mainAxisDefault = WidgetPlacement.floatDimension(getContext(), R.dimen.window_world_width); | ||
| mainAxisMinMax = Pair.create(minWorldSize.first, maxWorldSize.first); | ||
| } else { | ||
| // vertical orientation | ||
| mainAxisCurrent = getWindowHeight() - mBorderWidth * 2; | ||
| mainAxisCurrent = (getWindowHeight() - mBorderWidth * 2)* WidgetPlacement.worldToDpRatio(getContext()); |
There was a problem hiding this comment.
Nit: add a space between ) and *
Fix an error in the calculation of the size of a fullscreen window, where we were using the current window size in DP instead of converting it to our 3D world dimensions.
felipeerias
force-pushed
the
felipeerias/correctFullscrSize
branch
from
743866a
to
2a91b1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an error in the calculation of the size of a fullscreen window, where we were using the current window size in DP instead of converting it to our 3D world dimensions.