[OpenXR] Fix a regression when emulating a controller in WebXR #1512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When eye tracking navigation was introduced in c94ab62 it required some changes in the code that emulates a controller from a hand. It was basically just making that code aware of eye tracking in order not to use the hand aim but the eye gaze. That required some code refactorings. In one of them the grip space flag was removed from the initialization of flags and set later inside an if block. The problem was that we were setting that flag but at the same time removing the previous ones as we used a " = " instead of a " |= ".
|
It's easy to test
Works as expected with the patch |
felipeerias
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When eye tracking navigation was introduced in c94ab62 it required some changes in the code that emulates a controller from a hand. It was basically just making that code aware of eye tracking in order not to use the hand aim but the eye gaze.
That required some code refactorings. In one of them the grip space flag was removed from the initialization of flags and set later inside an if block. The problem was that we were setting that flag but at the same time removing the previous ones as we used a " = " instead of a " |= ".