[OpenXR] Add basic support for WebXR AR module #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this is increasing the version of the protocol used to talk to the Web Engine during WebXR sessions. This means that this change breaks WebXR support. We need to land the chromium backend change and also upload a new patch for Gecko to adapt it to work with this new protocol version. |
javifernandez
requested changes
Aug 13, 2024
javifernandez
approved these changes
Aug 20, 2024
|
This change requires Igalia/wolvic-gecko-patches#5, otherwise WebXR will break in the Gecko backend |
The Assertions.h file was using a Throw() inline method defined in OpenXRHelpers.h in several macros. There were several problems with that: 1. The macros would only work if the file including Assertions.h was also including OpenXRHelpers.h. That's wrong, Assertions.h should not depend on that 2. Assertions.h should not have any dependency with OpenXR headers This was unnoticed because files using those macros were already including OpenXRHelpers.h. As soon as I tried to use it in non OpenXR files it started to generate compiler errors.
Wolvic can now start and render WebXR's immersive-ar sessions for those devices supporting passthrough, either via non-opaque blend modes or passthrough compositor layers. This requires a few changes in the communication protocol with the web engine: 1. pass the available blend modes to the web engine so it can select the desired one depending on the requested WebXR session. 2. use the selected blend mode from the web engine to render the immersive scene 3. notify Wolvic about the type of WebXR session (AR/VR) Change #3 is required for those devices that do support passthrough but not via AR blend modes. Examples of those are the Meta devices that implement passthrough via a passthrough compositor layer. Note that WebXR's session type will prevail over the current passthrough status in standalone mode. There are 4 different scenarios (PT stands for passthrough): 1. PT ON, VR session: PT will be disabled on entering and reenabled on exiting 2. PT ON, AR session: PT will be activated all the time 3. PT OFF, VR session: PT will be off all the time 4. PT OFF, AR session: PT will be activated on entering and reenabled on exiting This change requires Igalia/wolvic-chromium#114 which implements the required bits on the Chromium backend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wolvic can now start and render WebXR's immersive-ar sessions for those devices supporting passthrough, either via non-opaque blend modes or passthrough compositor layers.
This requires a few changes in the communication protocol with the web engine:
Change #3 is required for those devices that do support passthrough but not via AR blend modes. Examples of those are the Meta devices that implement passthrough via a passthrough compositor layer.
Note that WebXR's session type will prevail over the current passthrough status in standalone mode. There are 4 different scenarios (PT stands for passthrough):
This change requires
Igalia/wolvic-chromium#114 which implements the required bits on the Chromium backend.
Fixes #242