Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow for signing multiple callsign domains and private keys #66

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

allow for signing multiple callsign domains and private keys #66

wants to merge 13 commits into from

Conversation

bikehara-ias
Copy link
Contributor

No description provided.

cmlight
cmlight requested changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@cmlight cmlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the logging-related function signature change partially bleeds into this PR, so I am not sure it is mergeable in this state.

@bikehara-ias
Copy link
Contributor Author

yes, they are built off of each other. once the other PRs are merged, this PR will be all good.

@bikehara-ias bikehara-ias marked this pull request as draft February 17, 2022 19:22
@bikehara-ias bikehara-ias marked this pull request as ready for review March 2, 2022 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmlight cmlight cmlight approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bikehara-ias @cmlight @bretkikehara