Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pieces-cli 1.6.2 #185625

Merged
merged 3 commits into from
Sep 17, 2024
Merged

pieces-cli 1.6.2 #185625

merged 3 commits into from
Sep 17, 2024

Conversation

nathan-courtney-pieces
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Our team at Pieces.app has completely redone our CLI tool and replaced all the existing URLs

This cask file should reflect all of those changes.

However, I am having issues running brew audit --cask --online pieces-cli as it seems to pull the one that is currently in homebrew-cask.

I have attempted to clear all caches, tap/untap my forked repo but alas, I cannot seem to get it to audit our new version. Help with this would be much appreciated if there are issues with our new CLI and/or the cask file.

I am also not aware of any cached resources at this moment that need to be zapped.

Thanks in advance!

@BrewTestBot BrewTestBot added automerge-skip missing zap Cask is missing a zap stanza, please add one. labels Sep 16, 2024
@krehel
Copy link
Member

krehel commented Sep 16, 2024

I am going to force push this to get it straightened out. One minor update on livecheck as we should be able to use json, but otherwise ok.

Please don't merge upstream/master into it. 😄

@nathan-courtney-pieces
Copy link
Contributor Author

@krehel

Okay! Thank you very much! It's been a year or two since I've dealt with making homebrew prs, I appreciate your help and patience

@krehel
Copy link
Member

krehel commented Sep 16, 2024

So one thing that will really help is if this is in its own branch on your side. I am probably not going to be able to edit this as it is directly in your remote master, unfortunately.

@nathan-courtney-pieces
Copy link
Contributor Author

@krehel

I have given you access as a collaborator to the repository if that will suffice. Otherwise I can branch off and re-submit the PR, although I believe I will have to close this PR first

@nathan-courtney-pieces
Copy link
Contributor Author

Also just to clarify, you mean a branch off of Homebrew/homebrew-cask and not a branch off my forked repo

@BrewTestBot BrewTestBot removed the missing zap Cask is missing a zap stanza, please add one. label Sep 16, 2024
@khipp khipp changed the title Update pieces-cli 1.6.2 pieces-cli 1.6.2 Sep 17, 2024
Adding folder location to be zapped for uninstall
Copy link
Member

@khipp khipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@khipp khipp merged commit 95a7d7e into Homebrew:master Sep 17, 2024
8 checks passed
@nathan-courtney-pieces
Copy link
Contributor Author

Thank you as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants