Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proton-mail: change download url #185415

Merged
merged 2 commits into from
Sep 17, 2024
Merged

proton-mail: change download url #185415

merged 2 commits into from
Sep 17, 2024

Conversation

traktuner
Copy link
Contributor

@traktuner traktuner commented Sep 14, 2024

Since the Proton Mail desktop app is now on version 1.1.0 and GitHub releases only show versions up to 1.0.6, I thought it would be good to change the download url to the non-versioned one which is hosted on proton.me
Unfortunately, there is no versioned url available.

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@krehel
Copy link
Member

krehel commented Sep 14, 2024

Hey @EpokK and @flavienbonvin! Apologies for the tag here, but seems the GitHub version of proton-mail is a bit behind Proton's site - should we pivot to using the version directly from Proton?

Also a note in case this 1.1.0 version is supposed to be on GitHub and somehow didn't make it!

Thanks so much!

@krehel krehel added the upstream Issue which needs to be resolved by the upstream project. label Sep 14, 2024
Copy link
Member

@samford samford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Thanks!

@samford samford merged commit 7c72f9f into Homebrew:master Sep 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream Issue which needs to be resolved by the upstream project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants