Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword descriptions that are too long #176542

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Conversation

samford
Copy link
Member

@samford samford commented Jun 12, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

We're working on getting brew style working again (Homebrew/brew#17482) for some circumstances where it was broken (e.g., checking taps) and brew CI is surfacing some more issues in homebrew/cask. This PR rewords description values that are longer than 80 characters.

There are also some shellcheck issues to resolve in the workflows here but I'm going to create a separate PR for that, so we can easily revert it if it breaks something.

@samford samford added the ci-syntax-only Only run syntax checks on CI. Use only for bulk changes. label Jun 12, 2024
@miccal miccal merged commit 945fa59 into master Jun 12, 2024
11 checks passed
@miccal miccal deleted the brew-style-description-fixes branch June 12, 2024 20:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip ci-syntax-only Only run syntax checks on CI. Use only for bulk changes. outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants