Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color prop for checkbox icon #374

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cnkeats
Copy link
Contributor

@cnkeats cnkeats commented Mar 31, 2022

fixes #372

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 31, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6106e34:

Sandbox Source
React Configuration

@aVileBroker
Copy link
Contributor

aVileBroker commented Apr 8, 2022

So, I know the AC in the ticket said "regardless of the variant and checkbox color" but I don't think that makes sense when actually trying it (see screenshot from codesandbox)

image

I would think the color prop would just change the general color of the checkbox (in this case where the green is), and we should be able to override the icon color separately

@aVileBroker
Copy link
Contributor

Being able to control both would give us ultimate control

giphy.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkbox | Add color prop to allow full customization of checkbox color
3 participants