Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use search to get datasets, as it is significantly faster #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

amercader
Copy link

Getting stuff from the search index is much faster than querying the DB

@amercader
Copy link
Author

I'm not entirely sure how the keywords property needs to be handled. It looks like a comma separated string was generated on data.json but the spec [1] says an array of strings?

Field keyword
Cardinality (1,n)
Required Yes, always
Accepted Values Array of strings
Usage Notes Surround each keyword with quotes. Separate keywords with commas.
Example {"keyword": ["squash","vegetables","veggies","greens","leafy","spinach","kale","nutrition","tomatoes","tomatos"]}

[1] http://project-open-data.github.io/schema/

@JoshData
Copy link
Contributor

Why don't we just revise current_package_list_with_resources to use search as its backend rather than the database?

@amercader
Copy link
Author

Fair enough, but that would involve more testing, reviewing and waiting for the next CKAN release.

@JoshData
Copy link
Contributor

JoshData commented Nov 1, 2013

If you patch CKAN I'll merge this pull request. :-P

Meanwhile, my contract with HHS has officially ended so if and until it gets renewed I'm on break from this repo.

@amercader
Copy link
Author

OK I'm not using this extension, was just evaluating it for other stuff, spotted this and thought it would be helpful for users. It can definitely stay in the PR purgatory for a while 🐢

@JoshData JoshData mentioned this pull request Dec 1, 2013
zr2d2 pushed a commit that referenced this pull request Jan 15, 2015
Release 1.23 - Schema 1.1 Updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants