Improve is_file and posix_searchpath #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
apocelipes
commented
Jun 8, 2024
apocelipes
commented
- On unix-like systems, use stat to check if the path is a file, this is more clear and faster than using fopen
- use is_file instead of access, which is more portable and can give us correct results under a setuid/setgid program (access only uses the real UID and real GID sometime can run into problems)
- use stat to check if the path is a file, this is more clear and faster than using fopen - use is_file instead of access, which is more portable and can give us correct results under a setuid/setgid program (access only use the real UID and real GID)
dtschump
added a commit
that referenced
this pull request
Jun 8, 2024
|
Thanks for the contribution. |
OK. I got it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.