Exclude Filestore module from integration test #2725
+101
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add integration test `pre_create_task` `remove_modules`
rohitramu
requested changes
Jun 27, 2024
|
|
||
| import yaml # pip install pyyaml | ||
|
|
||
| def delete_module(bp, mod_id: str): |
There was a problem hiding this comment.
If we print to console in this method, will it show up in CloudBuild logs? If so, I think it would be really helpful to see in the logs exactly which modules were removed from the blueprint. It would also be really helpful to see two more artifacts:
- Original blueprint
- Modified blueprint
Maybe we could save them in GCS and reference them in our CloudBuild yaml like this?
https://cloud.google.com/build/docs/building/store-artifacts-in-cloud-storage
At the very least, for this PR, it would be good to print the blueprint before and after modification to the log.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre_create_taskremove_modules;