Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Commit #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions api/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,3 +79,16 @@ async def brew():
status_code=status.HTTP_418_IM_A_TEAPOT,
detail="Cannot brew coffee with a teapot!"
)

@app.get("/search/author/")
async def search_by_author(author: str):
return (book for book in books if author in book.author)

@app.get("/search/pub_year/")
async def search_by_pub_year(year: int):
return (book for book in books if book.publication_year == year)

@app.get('/info/average_rating')
async def get_average_rating():
ratings = [book.rating for book in books]
return sum(ratings) / len(ratings)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not handle books without ratings!

4 changes: 3 additions & 1 deletion api/schema/book.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ class BookBase(BaseModel):
author: str
publication_year: Optional[int] = None
rating: Optional[int] = None
genre: str
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are benefits to using a string versus an enum here. For a quick implementation, string is fine! I would recommend making this field optional, however.


# TODO
# Add a 'genre' field here. You'll need to add it in a few other places as well!
Expand All @@ -24,7 +25,8 @@ def from_base(base: BookBase, id: int):
title = base.title,
author = base.author,
publication_year = base.publication_year,
rating = base.rating
rating = base.rating,
genre = base.genre
)


Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ version = "0.1.0"
description = "Example repo for 04APR New To Tech session"
authors = ["Matt <[email protected]>"]
readme = "README.md"
package-mode = false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for this change - the problem was something else


[tool.poetry.dependencies]
python = "^3.12"
Expand Down