Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odbc: connection-string allow any freetds.conf option #420

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kokan
Copy link
Contributor

@Kokan Kokan commented Sep 13, 2021

The aim is to be transparent, and allow any freetds.conf configuration option in the ODBC connection-string, so user do not require freetds.conf string.

The aim is to be transparent, and allow any freetds.conf configuration option in the ODBC connection-string, so user do not require freetds.conf string.

Signed-off-by: Kokan <[email protected]>
@fziglio
Copy link

fziglio commented Sep 16, 2021

The patch seems sensible. Some considerations:

  • the options in ODBC are case insensitive, the option in libTDS are case sensitive, I think he easiest fix for this inconsistency would be to have all case insentitive;
  • there's no check for function result, I think we should consider valid_configuration field in odbc_parse_connect_string;
  • odbc_parse_connect_string fills parsed_params for the supported ODBC parameters but not for libTDS options. This feature is used to fill ConnStrOut in SQLDriverConnect allowing to expand the connection string to a full independent connection string. I think we can ignore this but it would be better if we could support this too.

@Kokan
Copy link
Contributor Author

Kokan commented Sep 17, 2021

Thanks for the feedback. I'll update the PR with your points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants