Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pig latin versions for a name that is more clear #96

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

trescube
Copy link

@trescube trescube commented Jun 4, 2020

Pig latin makes for very confusing code and yet another barrier to entry for devs. This PR changes efineday and equireray with the more readable testLoaderDefine and testLoaderRequire.

If these names don't quite capture the nuance of their purpose, let me know and I'll update.

@trescube trescube self-assigned this Jun 4, 2020
@tomwayson
Copy link
Member

tomwayson commented Jun 4, 2020

What we are renaming are the global require and define provided by Ember's loader, so emberLoaderRequre and emberLoaderDefine would be more accurate names, and maybe emberRequire and emberDefine for brevity's sake.

This should be tested (npm linked) in the Hub app . I know we will need to at least change the places we've done this #95 (comment), as long as we are continuing to do that.

If you can confirm that it works over there, I'll approve this and cut a release that you can PR to the Hub app. In other words, I'm not opposed to this as long as I don't have to do anything other than cut a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants